Using the information in this guide you will be able to fix launcher crashing issues for both Generals and Generals Zero Hour.
FIXES
1) Install and Launch C&C Generals
Note: Will likely crash on the launcher
2) Install and Launch C&C Generals Zero Hour
Note: Will likely also crash
3) Enable Compatibility Mode
3A) In the game folder for Generals, right click on the application file
3B) Select “Properties”
3C) In the compatibility tab, enable compatibility mode
3D) Select “Windows XP (Service Pack 2)
3E) Repeat for Generals Zero Hour
Note: You can find the game folder from Steam by right clicking on the game and selecting “Browse Local Files”
4) Edit the Options.Ini files
4A) Go to C:\Users[Your Username]\Documents\Command and Conquer Generals Data
4B) Open the Options.ini file (Can edit using notebook)
4C) Add a line saying Resolution = 1920 1080 (Use your screen resolution if not 1920×1080)
4D) Repeat for Generals Zero Hour
Note: If the INI file is missing, relaunch the game and it will populate
5) Edit the Steam Launch Options
5A) In Steam, right click on Generals and select Properties
5B) In the Advanced Launch Options field add -xres 1920 -yres 1080 (Use your screen resolution if not 1920×1080)
5C) Repeat for Generals Zero Hour
6) Delete or rename the “dbghelp.dll” file in each game folder
7) Relaunch Generals and exit
Note: You must relaunch Generals in order for Generals Zero Hour to work.
8) Launch and play Generals Zero Hour as normal!